• Masami Hiramatsu (Google)'s avatar
    tracing: fgraph: Fix to add new fgraph_ops to array after ftrace_startup_subops() · a069a22f
    Masami Hiramatsu (Google) authored
    Since the register_ftrace_graph() assigns a new fgraph_ops to
    fgraph_array before registring it by ftrace_startup_subops(), the new
    fgraph_ops can be used in function_graph_enter().
    
    In most cases, it is still OK because those fgraph_ops's hashtable is
    already initialized by ftrace_set_filter*() etc.
    
    But if a user registers a new fgraph_ops which does not initialize the
    hash list, ftrace_ops_test() in function_graph_enter() causes a NULL
    pointer dereference BUG because fgraph_ops->ops.func_hash is NULL.
    
    This can be reproduced by the below commands because function profiler's
    fgraph_ops does not initialize the hash list;
    
     # cd /sys/kernel/tracing
     # echo function_graph > current_tracer
     # echo 1 > function_profile_enabled
    
    To fix this problem, add a new fgraph_ops to fgraph_array after
    ftrace_startup_subops(). Thus, until the new fgraph_ops is initialized,
    we will see fgraph_stub on the corresponding fgraph_array entry.
    
    Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>
    Cc: Florent Revest <revest@chromium.org>
    Cc: Martin KaFai Lau <martin.lau@linux.dev>
    Cc: bpf <bpf@vger.kernel.org>
    Cc: Sven Schnelle <svens@linux.ibm.com>
    Cc: Alexei Starovoitov <ast@kernel.org>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
    Cc: Daniel Borkmann <daniel@iogearbox.net>
    Cc: Alan Maguire <alan.maguire@oracle.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Guo Ren <guoren@kernel.org>
    Link: https://lore.kernel.org/172398528350.293426.8347220120333730248.stgit@devnote2
    Fixes: c132be2c ("function_graph: Have the instances use their own ftrace_ops for filtering")
    Signed-off-by: default avatarMasami Hiramatsu (Google) <mhiramat@kernel.org>
    Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
    a069a22f
fgraph.c 37.3 KB