• Lijun Pan's avatar
    ibmvnic: fix login buffer memory leak · a0c8be56
    Lijun Pan authored
    Commit 34f0f4e3 ("ibmvnic: Fix login buffer memory leaks") frees
    login_rsp_buffer in release_resources() and send_login()
    because handle_login_rsp() does not free it.
    Commit f3ae59c0 ("ibmvnic: store RX and TX subCRQ handle array in
    ibmvnic_adapter struct") frees login_rsp_buffer in handle_login_rsp().
    It seems unnecessary to free it in release_resources() and send_login().
    There are chances that handle_login_rsp returns earlier without freeing
    buffers. Double-checking the buffer is harmless since
    release_login_buffer and release_login_rsp_buffer will
    do nothing if buffer is already freed.
    
    Fixes: f3ae59c0 ("ibmvnic: store RX and TX subCRQ handle array in ibmvnic_adapter struct")
    Fixes: 34f0f4e3 ("ibmvnic: Fix login buffer memory leaks")
    Signed-off-by: default avatarLijun Pan <ljp@linux.ibm.com>
    Link: https://lore.kernel.org/r/20201219213919.21045-1-ljp@linux.ibm.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
    a0c8be56
ibmvnic.c 150 KB