• James Hogan's avatar
    MIPS: smp.c: Fix uninitialised temp_foreign_map · d825c06b
    James Hogan authored
    When calculate_cpu_foreign_map() recalculates the cpu_foreign_map
    cpumask it uses the local variable temp_foreign_map without initialising
    it to zero. Since the calculation only ever sets bits in this cpumask
    any existing bits at that memory location will remain set and find their
    way into cpu_foreign_map too. This could potentially lead to cache
    operations suboptimally doing smp calls to multiple VPEs in the same
    core, even though the VPEs share primary caches.
    
    Therefore initialise temp_foreign_map using cpumask_clear() before use.
    
    Fixes: cccf34e9 ("MIPS: c-r4k: Fix cache flushing for MT cores")
    Signed-off-by: default avatarJames Hogan <james.hogan@imgtec.com>
    Cc: Paul Burton <paul.burton@imgtec.com>
    Cc: linux-mips@linux-mips.org
    Patchwork: https://patchwork.linux-mips.org/patch/12759/Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
    d825c06b
smp.c 11.5 KB