• Vladimir Oltean's avatar
    spi: spi-fsl-dspi: Implement .max_message_size method for EOQ mode · a3185c38
    Vladimir Oltean authored
    When it gets set, End Of Queue Flag halts the DSPI controller and forces
    the chip select signal to deassert.
    
    This operating mode is not ideal, but it is used for the DSPI
    instantiations where there is no other notification from the controller
    that the data in the FIFO has finished transmission. So in practice, it
    means that transmitting buffers larger than the FIFO size will yield
    unpredictable results.
    
    The only controller that operates in EOQ mode is MCF5441X (Coldfire). I
    would say that the way EOQ is used (and documented in the reference
    manual, too) on this chip is incorrect, and I would personally migrate
    it to TCFQ, but that's notably worse in terms of performance (it can
    only use 1 entry of the 16-deep FIFO) and if this limitation didn't
    bother any Coldfire DSPI user so far, it's likely that we just need to
    throw an error for larger buffers to make sure that callers are aware
    their transfers are getting truncated/split.
    Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
    Link: https://lore.kernel.org/r/20200304220044.11193-7-olteanv@gmail.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
    a3185c38
spi-fsl-dspi.c 31.6 KB