• Jiri Slaby's avatar
    serial: Char: cyclades, fix compiler warning · a357e777
    Jiri Slaby authored
    With gcc 4.0.2:
    drivers/char/cyclades.c: In function 'cyy_interrupt':
    drivers/char/cyclades.c:581: warning: 'info' may be used uninitialized in this function
    
    introduced by
    
    : commit 3aeea5b9
    : Author:     Jiri Slaby <jirislaby@gmail.com>
    : AuthorDate: Sat Sep 19 13:13:16 2009 -0700
    : Commit:     Live-CD User <linux@linux.site>
    : CommitDate: Sat Sep 19 13:13:16 2009 -0700
    :
    :    cyclades: introduce cyy_readb/writeb
    
    In fact the true branch which uses uninitialized 'info' can never
    happen because chip is always less than ->nchips and channel is
    always less than 4 which we alloc.
    
    So behave similar to rx handling and remove the test completely.
    
    I wonder why gcc 4.4.1 doesn't spit a word.
    Reported-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Cc: Alan Cox <alan@linux.intel.com>
    Signed-off-by: default avatarJiri Slaby <jslaby@novell.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    a357e777
cyclades.c 112 KB