• Lorenzo Colitti's avatar
    net: ipv6: Fix oif in TCP SYN+ACK route lookup. · a36dbdb2
    Lorenzo Colitti authored
    net-next commit 9c76a114, ipv6: tcp_ipv6 policy route issue, had
    a boolean logic error that caused incorrect behaviour for TCP
    SYN+ACK when oif-based rules are in use. Specifically:
    
    1. If a SYN comes in from a global address, and sk_bound_dev_if
       is not set, the routing lookup has oif set to the interface
       the SYN came in on. Instead, it should have oif unset,
       because for global addresses, the incoming interface doesn't
       necessarily have any bearing on the interface the SYN+ACK is
       sent out on.
    2. If a SYN comes in from a link-local address, and
       sk_bound_dev_if is set, the routing lookup has oif set to the
       interface the SYN came in on. Instead, it should have oif set
       to sk_bound_dev_if, because that's what the application
       requested.
    Signed-off-by: default avatarLorenzo Colitti <lorenzo@google.com>
    Acked-by: default avatarHannes Frederic Sowa <hannes@stressinduktion.org>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    a36dbdb2
tcp_ipv6.c 51.8 KB