• Jason A. Donenfeld's avatar
    random: do not export add_vmfork_randomness() unless needed · a4107d34
    Jason A. Donenfeld authored
    Since add_vmfork_randomness() is only called from vmgenid.o, we can
    guard it in CONFIG_VMGENID, similarly to how we do with
    add_disk_randomness() and CONFIG_BLOCK. If we ever have multiple things
    calling into add_vmfork_randomness(), we can add another shared Kconfig
    symbol for that, but for now, this is good enough. Even though
    add_vmfork_randomess() is a pretty small function, removing it means
    that there are only calls to crng_reseed(false) and none to
    crng_reseed(true), which means the compiler can constant propagate the
    false, removing branches from crng_reseed() and its descendants.
    
    Additionally, we don't even need the symbol to be exported if
    CONFIG_VMGENID is not a module, so conditionalize that too.
    
    Cc: Dominik Brodowski <linux@dominikbrodowski.net>
    Cc: Theodore Ts'o <tytso@mit.edu>
    Signed-off-by: default avatarJason A. Donenfeld <Jason@zx2c4.com>
    a4107d34
random.c 48.2 KB