• Li Zefan's avatar
    cgroup: delay the clearing of cgrp->kn->priv · a4189487
    Li Zefan authored
    Run these two scripts concurrently:
    
        for ((; ;))
        {
            mkdir /cgroup/sub
            rmdir /cgroup/sub
        }
    
        for ((; ;))
        {
            echo $$ > /cgroup/sub/cgroup.procs
            echo $$ > /cgroup/cgroup.procs
        }
    
    A kernel bug will be triggered:
    
    BUG: unable to handle kernel NULL pointer dereference at 00000038
    IP: [<c10bbd69>] cgroup_put+0x9/0x80
    ...
    Call Trace:
     [<c10bbe19>] cgroup_kn_unlock+0x39/0x50
     [<c10bbe91>] cgroup_kn_lock_live+0x61/0x70
     [<c10be3c1>] __cgroup_procs_write.isra.26+0x51/0x230
     [<c10be5b2>] cgroup_tasks_write+0x12/0x20
     [<c10bb7b0>] cgroup_file_write+0x40/0x130
     [<c11aee71>] kernfs_fop_write+0xd1/0x160
     [<c1148e58>] vfs_write+0x98/0x1e0
     [<c114934d>] SyS_write+0x4d/0xa0
     [<c16f656b>] sysenter_do_call+0x12/0x12
    
    We clear cgrp->kn->priv in the end of cgroup_rmdir(), but another
    concurrent thread can access kn->priv after the clearing.
    
    We should move the clearing to css_release_work_fn(). At that time
    no one is holding reference to the cgroup and no one can gain a new
    reference to access it.
    
    v2:
    - move RCU_INIT_POINTER() into the else block. (Tejun)
    - remove the cgroup_parent() check. (Tejun)
    - update the comment in css_tryget_online_from_dir().
    
    Cc: <stable@vger.kernel.org> # 3.15+
    Reported-by: default avatarToralf Förster <toralf.foerster@gmx.de>
    Signed-off-by: default avatarZefan Li <lizefan@huawei.com>
    Signed-off-by: default avatarTejun Heo <tj@kernel.org>
    a4189487
cgroup.c 150 KB