• Amelie Delaunay's avatar
    dmaengine: stm32-dma: rework irq handler to manage error before xfer events · a44d9d72
    Amelie Delaunay authored
    To better understand error that can be detected by the DMA controller,
    manage the error flags before the transfer flags.
    This way, it is possible to know if the FIFO error flag is set for an
    over/underrun condition or a FIFO level error.
    When a FIFO over/underrun condition occurs, the data is not lost because
    peripheral request is not acknowledged by the stream until the over/
    underrun condition is cleared. If this acknowledge takes too much time,
    the peripheral itself may detect an over/underrun condition of its internal
    buffer and data might be lost.
    That's why in case the FIFO error flag is set, we check if the channel is
    disabled or not, and if a Transfer Complete flag is set, which means that
    the channel is disabled because of the end of transfer.
    Because channel is disabled by hardware either by a FIFO level error, or by
    an end of transfer.
    Signed-off-by: default avatarAmelie Delaunay <amelie.delaunay@st.com>
    Link: https://lore.kernel.org/r/20201120143320.30367-2-amelie.delaunay@st.comSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
    a44d9d72
stm32-dma.c 41.3 KB