• Suraj Jitindar Singh's avatar
    selftests/powerpc: Remove -flto from common CFLAGS · a4cf0a2e
    Suraj Jitindar Singh authored
    LTO can cause GCC to inline some functions which have attributes set.
    The act of inlining the functions can lead to GCC forgetting about the
    attributes which leads to incorrect tests.
    
    Notable example being: __attribute__((__target__("no-vsx")))
    
    LTO can also interact strangely with custom assembly functions and cause
    tests to intermittently fail.
    
    Both these cases are hard to detect and require manual inspection of
    binaries which is unlikely to happen for all tests. Furthermore, LTO
    optimisations are not necessary for selftests and correctness is
    paramount and as such it is best to disable LTO.
    
    LTO can be enabled on a per test basis.
    
    A pseries_le_defconfig kernel on a POWER8 was used to determine that the
    same subset of selftests pass and fail with and without -flto in the
    common Makefile.
    Signed-off-by: default avatarSuraj Jitindar Singh <sjitindarsingh@gmail.com>
    Reviewed-by: default avatarCyril Bur <cyrilbur@gmail.com>
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    a4cf0a2e
Makefile 1.11 KB