• Douglas Gilbert's avatar
    [PATCH] sg jiffy library calls [was: sg kill local jiffies · a4d56cc4
    Douglas Gilbert authored
    Douglas Gilbert wrote:
    > It has been reported that the change to sg.c in lk 2.6.9-rc1-bk5
    > to use library jiffy functions breaks sg (albeit under vmware).
    > Evidentally sg devices are no longer recognised after that change.
    > 
    > Reverting that changeset removes the problem. Strange, it is not
    > obvious why.
    > 
    > At some stage I must have detected negative time spans (yeh yeh it
    > never happens) and my versions returned 0 in this case; otherwise
    > the implementations look very similar.
    
    The following patch fixes the problem. It is
    against lk 2.6.9-rc1-bk7 (i.e. after "standard"
    jiffy_to_millisecs macros replaced sg versions).
    
    Change:
        - make sure a (large) user supplied timeout value does
          not result in a negative timeout passed to the midlevel
    Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
    a4d56cc4
sg.c 83.4 KB