• Heiko Stuebner's avatar
    pinctrl/rockchip: add a queue for deferred pin output settings on probe · e7165b1d
    Heiko Stuebner authored
    The separation of pinctrl and gpio drivers created a tiny window where
    a pinconfig setting might produce a null-pointer dereference.
    
    The affected device were rk3288-veyron devices in this case.
    
    Pinctrl-hogs are claimed when the pinctrl driver is registered,
    at which point their pinconfig settings will be applied.
    At this time the now separate gpio devices will not have been created
    yet and the matching driver won't have probed yet, making the gpio->foo()
    call run into a null-ptr.
    
    As probing is not really guaranteed to have been completed at a specific
    time, introduce a queue that can hold the output settings until the gpio
    driver has probed and will (in a separate patch) fetch the elements
    of the list.
    
    We expect the gpio driver to empty the list, but will nevertheless empty
    it ourself on remove if that didn't happen.
    
    Fixes: 9ce9a020 ("pinctrl/rockchip: drop the gpio related codes")
    Signed-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
    Link: https://lore.kernel.org/r/20210913224926.1260726-4-heiko@sntech.deSigned-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
    e7165b1d
pinctrl-rockchip.h 7.84 KB