• Christoph Lameter's avatar
    [PATCH] A new 10GB Ethernet Driver by Chelsio Communications · 8199d3a7
    Christoph Lameter authored
    A Linux driver for the Chelsio 10Gb Ethernet Network Controller by Chelsio
    (http://www.chelsio.com).  This driver supports the Chelsio N210 NIC and is
    backward compatible with the Chelsio N110 model 10Gb NICs.  It supports
    AMD64, EM64T and x86 systems.
    Signed-off-by: default avatarTina Yang <tinay@chelsio.com>
    Signed-off-by: default avatarScott Bardone <sbardone@chelsio.com>
    Signed-off-by: default avatarChristoph Lameter <christoph@lameter.com>
    
    Adrian said:
    
    - my3126.c is unused (because t1_my3126_ops isn't used anywhere)
    - what are the EXTRA_CFLAGS in drivers/net/chelsio/Makefile for?
    - $(cxgb-y) in drivers/net/chelsio/Makefile seems to be unneeded
    - completely unused global functions:
      - espi.c: t1_espi_get_intr_counts
      - sge.c: t1_sge_get_intr_counts
    - the following functions can be made static:
      - sge.c: t1_espi_workaround
      - sge.c: t1_sge_tx
      - subr.c: __t1_tpi_read
      - subr.c: __t1_tpi_write
      - subr.c: t1_wait_op_done
    
    shemminger said:
    
    The performance recommendations in cxgb.txt are common to all fast devices,
    and should be in one file rather than just for this device. I would rather
    see ip-sysctl.txt updated or a new file on tuning recommendations started.
    Some of them have consequences that aren't documented well.
    For example, turning off TCP timestamps risks data corruption from sequence wrap.
    
    A new driver shouldn't need so may #ifdef's unless you want to putit on older
    vendor versions of 2.4
    
    Some accessor and wrapper functions like:
            t1_pci_read_config_4
            adapter_name
            t1_malloc
    are just annoying noise.
    
    Why have useless dead code like:
    
    /* Interrupt handler */
    +static int pm3393_interrupt_handler(struct cmac *cmac)
    +{
    +       u32 master_intr_status;
    +/*
    +    1. Read master interrupt register.
    +    2. Read BLOCK's interrupt status registers.
    +    3. Handle BLOCK interrupts.
    +*/
    
    Jeff said:
    
    step 1:  kill all the OS wrappers.
    
     And do you really need hooks for multiple MACs, when only one MAC is
     really supported?  Typically these hooks are at a higher level anyway --
     struct net_device.
    
    From: Christoph Lameter <christoph@lameter
    
    Driver modified as suggested by Pekka Enberg, Stephen Hemminger and Andrian
    Bunk.  Reduces the size of the driver to ~260k.
    
    - clean up tabs
    - removed my3126.c
    - removed 85% of suni1x10gexp_regs.h
    - removed 80% of regs.h
    - removed various calls, renamed variables/functions.
    - removed system specific and other wrappers (usleep, msleep)
    - removed dead code
    - dropped redundant casts in osdep.h
    - dropped redundant check of kfree
    - dropped weird code (MODVERSIONS stuff)
    - reduced number of #ifdefs
    - use kcalloc now instead of kmalloc
    - Add information about known issues with the driver
    - Add information about authors
    Signed-off-by: default avatarScott Bardone <sbardone@chelsio.com>
    Signed-off-by: default avatarChristoph Lameter <christoph@lameter.com>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    
    diff -puN /dev/null Documentation/networking/cxgb.txt
    8199d3a7
tp.c 6.3 KB