• Hans de Goede's avatar
    ACPI: video: Add acpi_backlight=video quirk for Lenovo ThinkPad W530 · a5b2781d
    Hans de Goede authored
    The Lenovo ThinkPad W530 uses a nvidia k1000m GPU. When this gets used
    together with one of the older nvidia binary driver series (the latest
    series does not support it), then backlight control does not work.
    
    This is caused by commit 3dbc80a3 ("ACPI: video: Make backlight
    class device registration a separate step (v2)") combined with
    commit 5aa9d943 ("ACPI: video: Don't enable fallback path for
    creating ACPI backlight by default").
    
    After these changes the acpi_video# backlight device is only registered
    when requested by a GPU driver calling acpi_video_register_backlight()
    which the nvidia binary driver does not do.
    
    I realize that using the nvidia binary driver is not a supported use-case
    and users can workaround this by adding acpi_backlight=video on the kernel
    commandline, but the ThinkPad W530 is a popular model under Linux users,
    so it seems worthwhile to add a quirk for this.
    
    I will also email Nvidia asking them to make the driver call
    acpi_video_register_backlight() when an internal LCD panel is detected.
    So maybe the next maintenance release of the drivers will fix this...
    
    Fixes: 5aa9d943 ("ACPI: video: Don't enable fallback path for creating ACPI backlight by default")
    Cc: All applicable <stable@vger.kernel.org>
    Reviewed-by: default avatarMario Limonciello <mario.limonciello@amd.com>
    Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
    Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
    a5b2781d
video_detect.c 23.3 KB