• Vlad Buslov's avatar
    net/sched: act_ct: additional checks for outdated flows · a63b6622
    Vlad Buslov authored
    Current nf_flow_is_outdated() implementation considers any flow table flow
    which state diverged from its underlying CT connection status for teardown
    which can be problematic in the following cases:
    
    - Flow has never been offloaded to hardware in the first place either
    because flow table has hardware offload disabled (flag
    NF_FLOWTABLE_HW_OFFLOAD is not set) or because it is still pending on 'add'
    workqueue to be offloaded for the first time. The former is incorrect, the
    later generates excessive deletions and additions of flows.
    
    - Flow is already pending to be updated on the workqueue. Tearing down such
    flows will also generate excessive removals from the flow table, especially
    on highly loaded system where the latency to re-offload a flow via 'add'
    workqueue can be quite high.
    
    When considering a flow for teardown as outdated verify that it is both
    offloaded to hardware and doesn't have any pending updates.
    
    Fixes: 41f2c7c3 ("net/sched: act_ct: Fix promotion of offloaded unreplied tuple")
    Reviewed-by: default avatarPaul Blakey <paulb@nvidia.com>
    Signed-off-by: default avatarVlad Buslov <vladbu@nvidia.com>
    Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
    a63b6622
act_ct.c 39.7 KB