• Erik Hugne's avatar
    tipc: reassembly failures should cause link reset · a715b49e
    Erik Hugne authored
    If appending a received fragment to the pending fragment chain
    in a unicast link fails, the current code tries to force a retransmission
    of the fragment by decrementing the 'next received sequence number'
    field in the link. This is done under the assumption that the failure
    is caused by an out-of-memory situation, an assumption that does
    not hold true after the previous patch in this series.
    
    A failure to append a fragment can now only be caused by a protocol
    violation by the sending peer, and it must hence be assumed that it
    is either malicious or buggy.  Either way, the correct behavior is now
    to reset the link instead of trying to revert its sequence number.
    So, this is what we do in this commit.
    Signed-off-by: default avatarErik Hugne <erik.hugne@ericsson.com>
    Reviewed-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
    Signed-off-by: default avatarJon Maloy <jon.maloy@ericsson.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    a715b49e
link.c 73.8 KB