• Pavel Skripkin's avatar
    net: asix: fix uninit value bugs · a786e319
    Pavel Skripkin authored
    Syzbot reported uninit-value in asix_mdio_read(). The problem was in
    missing error handling. asix_read_cmd() should initialize passed stack
    variable smsr, but it can fail in some cases. Then while condidition
    checks possibly uninit smsr variable.
    
    Since smsr is uninitialized stack variable, driver can misbehave,
    because smsr will be random in case of asix_read_cmd() failure.
    Fix it by adding error handling and just continue the loop instead of
    checking uninit value.
    
    Added helper function for checking Host_En bit, since wrong loop was used
    in 4 functions and there is no need in copy-pasting code parts.
    
    Cc: Robert Foss <robert.foss@collabora.com>
    Fixes: d9fe64e5 ("net: asix: Add in_pm parameter")
    Reported-by: syzbot+a631ec9e717fb0423053@syzkaller.appspotmail.com
    Signed-off-by: default avatarPavel Skripkin <paskripkin@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    a786e319
asix_common.c 19.4 KB