• Lin Ma's avatar
    net: nfc: remove inappropriate attrs check · a799de0e
    Lin Ma authored
    Revert "NFC: fix attrs checks in netlink interface"
    This reverts commit 18917d51.
    
    Our checks found weird attrs present check in function
    nfc_genl_dep_link_down() and nfc_genl_llc_get_params(), which are
    introduced by commit 18917d51 ("NFC: fix attrs checks in netlink
    interface").
    
    According to its message, it should add checks for functions
    nfc_genl_deactivate_target() and nfc_genl_fw_download(). However, it
    didn't do that. In fact, the expected checks are added by
    (1) commit 385097a3 ("nfc: Ensure presence of required attributes in
    the deactivate_target handler") and
    (2) commit 280e3ebd ("nfc: Ensure presence of NFC_ATTR_FIRMWARE_NAME
    attribute in nfc_genl_fw_download()"). Perhaps something went wrong.
    
    Anyway, the attr NFC_ATTR_TARGET_INDEX is never accessed in callback
    nfc_genl_dep_link_down() and same for NFC_ATTR_FIRMWARE_NAME and
    nfc_genl_llc_get_params(). Thus, remove those checks.
    Signed-off-by: default avatarLin Ma <linma@zju.edu.cn>
    Link: https://lore.kernel.org/r/20240410034846.167421-1-linma@zju.edu.cnSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
    a799de0e
netlink.c 40.3 KB