• Nicholas Bellinger's avatar
    iscsi-target: Change BUG_ON to REJECT in iscsit_process_nop_out · 7cbfcc95
    Nicholas Bellinger authored
    This patch changes an incorrect use of BUG_ON to instead generate a
    REJECT + PROTOCOL_ERROR in iscsit_process_nop_out() code.  This case
    can occur with traditional TCP where a flood of zeros in the data
    stream can reach this block for what is presumed to be a NOP-OUT with
    a solicited reply, but without a valid iscsi_cmd pointer.
    
    This incorrect BUG_ON was introduced during the v3.11-rc timeframe
    with the following commit:
    
    commit 778de368
    Author: Nicholas Bellinger <nab@linux-iscsi.org>
    Date:   Fri Jun 14 16:07:47 2013 -0700
    
        iscsi/isert-target: Refactor ISCSI_OP_NOOP RX handling
    Reported-by: default avatarArshad Hussain <arshad.hussain@calsoftinc.com>
    Cc: stable@vger.kernel.org # 3.11+
    Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
    7cbfcc95
iscsi_target.c 127 KB