• Madadi Vineeth Reddy's avatar
    perf sched replay: Fix -r/--repeat command line option for infinity · a7cacaa0
    Madadi Vineeth Reddy authored
    Currently, the -r/--repeat option accepts values from 0 and complains
    for -1. The help section specifies:
    -r, --repeat <n>      repeat the workload replay N times (-1: infinite)
    
    The -r -1 option raises an error because replay_repeat is defined as
    an unsigned int.
    
    In the current implementation, the workload is repeated n times when
    -r <n> is used, except when n is 0.
    
    When -r is set to 0, the workload is also repeated once. This happens
    because when -r=0, the run_one_test function is not called. (Note that
    mutex unlocking, which is essential for child threads spawned to emulate
    the workload, happens in run_one_test.) However, mutex unlocking is
    still performed in the destroy_tasks function. Thus, -r=0 results in the
    workload running once coincidentally.
    
    To clarify and maintain the existing logic for -r >= 1 (which runs the
    workload the specified number of times) and to fix the issue with infinite
    runs, make -r=0 perform an infinite run.
    Reviewed-by: default avatarJames Clark <james.clark@arm.com>
    Signed-off-by: default avatarMadadi Vineeth Reddy <vineethr@linux.ibm.com>
    Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
    Link: https://lore.kernel.org/r/20240628071821.15264-1-vineethr@linux.ibm.comSigned-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
    a7cacaa0
perf-sched.txt 6.55 KB