• Christian Lamparter's avatar
    ata: sata_dwc_460ex: fix crash on offline links without an attached drive · a7e6de54
    Christian Lamparter authored
    This patch fixes Machine Check "Data Write PLB Error" which happens
    when libata-sff's ata_sff_dev_select is trying to write into the
    device_addr in order to select a drive. However, SATA has no master
    or slave devices like the old ATA Bus, therefore selecting a
    different drive is kind of pointless.
    
    Data Write PLB Error
    Oops: Machine check, sig: 7 [#1]
    PowerPC 44x Platform
    Modules linked in:
    CPU: 0 PID: 508 Comm: scsi_eh_0 Not tainted 4.6.0-rc3-next-20160412+ #10
    [...]
    NIP [c027e820] ata_sff_dev_select+0x3c/0x44
    LR [c027e810] ata_sff_dev_select+0x2c/0x44
    Call Trace:
    [cec31cd0] [c027da00] ata_sff_postreset+0x40/0xb4 (unreliable)
    [cec31ce0] [c027a03c] ata_eh_reset+0x5cc/0x928
    [cec31d60] [c027a840] ata_eh_recover+0x330/0x10bc
    [cec31df0] [c027bae0] ata_do_eh+0x4c/0xa4
    [...]
    Signed-off-by: default avatarChristian Lamparter <chunkeey@googlemail.com>
    Signed-off-by: default avatarTejun Heo <tj@kernel.org>
    a7e6de54
sata_dwc_460ex.c 35.9 KB