• Rob Herring's avatar
    amba: Retry adding deferred devices at late_initcall · 039599c9
    Rob Herring authored
    If amba bus devices defer when adding, the amba bus code simply retries
    adding the devices every 5 seconds. This doesn't work well as it
    completely unsynchronized with starting the init process which can
    happen in less than 5 secs. Add a retry during late_initcall. If the
    amba devices are added, then deferred probe takes over. If the
    dependencies have not probed at this point, then there's no improvement
    over previous behavior. To completely solve this, we'd need to retry
    after every successful probe as deferred probe does.
    
    The list_empty() check now happens outside the mutex, but the mutex
    wasn't necessary in the first place.
    
    This needed to use deferred probe instead of fragile initcall ordering
    on 32-bit VExpress systems where the apb_pclk has a number of probe
    dependencies (vexpress-sysregs, vexpress-config).
    
    Cc: John Stultz <john.stultz@linaro.org>
    Cc: Saravana Kannan <saravanak@google.com>
    Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
    Cc: Geert Uytterhoeven <geert+renesas@glider.be>
    Cc: Russell King <linux@armlinux.org.uk>
    Tested-by: default avatarSudeep Holla <sudeep.holla@arm.com>
    Reviewed-by: default avatarSudeep Holla <sudeep.holla@arm.com>
    Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
    Signed-off-by: default avatarRob Herring <robh@kernel.org>
    039599c9
bus.c 19.7 KB