Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • L linux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Kirill Smelkov
  • linux
  • Repository
You need to sign in or sign up before continuing.
  • linux
  • net
  • mac80211
  • iface.c
Find file BlameHistoryPermalink
  • Tetsuo Handa's avatar
    wifi: mac80211: do not abuse fq.lock in ieee80211_do_stop() · aa40d5a4
    Tetsuo Handa authored Jul 17, 2022
    lockdep complains use of uninitialized spinlock at ieee80211_do_stop() [1],
    for commit f856373e ("wifi: mac80211: do not wake queues on a vif
    that is being stopped") guards clear_bit() using fq.lock even before
    fq_init() from ieee80211_txq_setup_flows() initializes this spinlock.
    
    According to discussion [2], Toke was not happy with expanding usage of
    fq.lock. Since __ieee80211_wake_txqs() is called under RCU read lock, we
    can instead use synchronize_rcu() for flushing ieee80211_wake_txqs().
    
    Link: https://syzkaller.appspot.com/bug?extid=eceab52db7c4b961e9d6 [1]
    Link: https://lkml.kernel.org/r/874k0zowh2.fsf@toke.dk
    
     [2]
    Reported-by: default avatarsyzbot <syzbot+eceab52db7c4b961e9d6@syzkaller.appspotmail.com>
    Signed-off-by: default avatarTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
    Fixes: f856373e
    
     ("wifi: mac80211: do not wake queues on a vif that is being stopped")
    Tested-by: default avatarsyzbot <syzbot+eceab52db7c4b961e9d6@syzkaller.appspotmail.com>
    Acked-by: default avatarToke Høiland-Jørgensen <toke@kernel.org>
    Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
    Link: https://lore.kernel.org/r/9cc9b81d-75a3-3925-b612-9d0ad3cab82b@I-love.SAKURA.ne.jp
    [ pick up commit 3598cb6e ("wifi: mac80211: do not abuse fq.lock in ieee80211_do_stop()") from -next]
    Link: https://lore.kernel.org/all/87o7xcq6qt.fsf@kernel.org/
    
    
    Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
    aa40d5a4
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7