• Kinglong Mee's avatar
    btrfs: fix memory leak of fs_info in block group cache · aa66b0bb
    Kinglong Mee authored
    When starting up linux with btrfs filesystem, I got many memory leak
    messages by kmemleak as,
    
    unreferenced object 0xffff880066882000 (size 4096):
      comm "modprobe", pid 730, jiffies 4294690024 (age 196.599s)
      hex dump (first 32 bytes):
        00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
        00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
      backtrace:
        [<ffffffff8174d52e>] kmemleak_alloc+0x4e/0xb0
        [<ffffffff811d09aa>] kmem_cache_alloc_trace+0xea/0x1e0
        [<ffffffffa03620fb>] btrfs_alloc_dummy_fs_info+0x6b/0x2a0 [btrfs]
        [<ffffffffa03624fc>] btrfs_alloc_dummy_block_group+0x5c/0x120 [btrfs]
        [<ffffffffa0360aa9>] btrfs_test_free_space_cache+0x39/0xed0 [btrfs]
        [<ffffffffa03b5a74>] trace_raw_output_xfs_attr_class+0x54/0xe0 [xfs]
        [<ffffffff81002122>] do_one_initcall+0xb2/0x1f0
        [<ffffffff811765aa>] do_init_module+0x5e/0x1e9
        [<ffffffff810fec09>] load_module+0x20a9/0x2690
        [<ffffffff810ff439>] SyS_finit_module+0xb9/0xf0
        [<ffffffff81757daf>] entry_SYSCALL_64_fastpath+0x12/0x76
        [<ffffffffffffffff>] 0xffffffffffffffff
    unreferenced object 0xffff8800573f8000 (size 10256):
      comm "modprobe", pid 730, jiffies 4294690185 (age 196.460s)
      hex dump (first 32 bytes):
        00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
        00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
      backtrace:
        [<ffffffff8174d52e>] kmemleak_alloc+0x4e/0xb0
        [<ffffffff8119ca6e>] kmalloc_order+0x5e/0x70
        [<ffffffff8119caa4>] kmalloc_order_trace+0x24/0x90
        [<ffffffffa03620b3>] btrfs_alloc_dummy_fs_info+0x23/0x2a0 [btrfs]
        [<ffffffffa03624fc>] btrfs_alloc_dummy_block_group+0x5c/0x120 [btrfs]
        [<ffffffffa036603d>] run_test+0xfd/0x320 [btrfs]
        [<ffffffffa0366f34>] btrfs_test_free_space_tree+0x94/0xee [btrfs]
        [<ffffffffa03b5aab>] trace_raw_output_xfs_attr_class+0x8b/0xe0 [xfs]
        [<ffffffff81002122>] do_one_initcall+0xb2/0x1f0
        [<ffffffff811765aa>] do_init_module+0x5e/0x1e9
        [<ffffffff810fec09>] load_module+0x20a9/0x2690
        [<ffffffff810ff439>] SyS_finit_module+0xb9/0xf0
        [<ffffffff81757daf>] entry_SYSCALL_64_fastpath+0x12/0x76
        [<ffffffffffffffff>] 0xffffffffffffffff
    
    This patch lets btrfs using fs_info stored in btrfs_root for
    block group cache directly without allocating a new one.
    
    Fixes: d0bd4560 ("Btrfs: add fragment=* debug mount option")
    Signed-off-by: default avatarKinglong Mee <kinglongmee@gmail.com>
    Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
    aa66b0bb
btrfs-tests.c 5.75 KB