• Anton Vorontsov's avatar
    powerpc/85xx: Fix oops during MSI driver probe on MPC85xxMDS boards · fa644298
    Anton Vorontsov authored
    MPC85xx chips report the wrong value in feature reporting register,
    and that causes the following oops:
    
     Unable to handle kernel paging request for data at address 0x00000c00
     Faulting instruction address: 0xc0019294
     Oops: Kernel access of bad area, sig: 11 [#1]
     MPC8569 MDS
     Modules linked in:
     [...]
     NIP [c0019294] mpic_set_irq_type+0x2f0/0x368
     LR [c0019124] mpic_set_irq_type+0x180/0x368
     Call Trace:
     [ef851d60] [c0019124] mpic_set_irq_type+0x180/0x368 (unreliable)
     [ef851d90] [c007958c] __irq_set_trigger+0x44/0xd4
     [ef851db0] [c007b550] set_irq_type+0x40/0x7c
     [ef851dc0] [c0004a60] irq_create_of_mapping+0xb4/0x114
     [ef851df0] [c0004af0] irq_of_parse_and_map+0x30/0x40
     [ef851e20] [c0405678] fsl_of_msi_probe+0x1a0/0x328
     [ef851e60] [c02e6438] of_platform_device_probe+0x5c/0x84
     [...]
    
    This is because mpic_alloc() assigns wrong values to
    mpic->isu_{size,shift,mask}, and things eventually break when
    _mpic_irq_read() is trying to use them.
    
    This patch fixes the issue by enabling MPIC_BROKEN_FRR_NIRQS quirk.
    Signed-off-by: default avatarAnton Vorontsov <avorontsov@ru.mvista.com>
    Signed-off-by: default avatarKumar Gala <galak@kernel.crashing.org>
    fa644298
mpc85xx_mds.c 8.91 KB