• Oren Givon's avatar
    iwlwifi: mvm: fix txq aggregation bug · aba2ee27
    Oren Givon authored
    commit 2c4a247e upstream.
    
    Fix an issue where nullfunc frames and block ack requests
    had the same tid as aggregation frames and were queued on
    a non aggregation queue. The pending frames counter included
    those frames but the check whether to decrement the pending
    frames counter relied on the tid status and not on the txq id.
    The result was an inconsistent state of the pending frames
    counter followed by a failure to remove the station.
    This failure triggered SYSASSERT 0x3421.
    
    In addition, fix a situation in DQA mode where the number
    of pending frames turned negative. This was due to the TX queue
    being on the IWL_EMPTYING_HW_QUEUE_DELBA state and its frames
    were still decremented.
    
    Even though the SYSASSERT issue is fixed when DQA is disabled,
    the issue is not completely solved when DQA is enabled and
    should still be fixed.
    Signed-off-by: default avatarOren Givon <oren.givon@intel.com>
    Fixes: cf961e16 ("iwlwifi: mvm: support dqa-mode agg on non-shared queue")
    Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    aba2ee27
tx.c 48.9 KB