• Dan Aloni's avatar
    sunrpc: fix xs_read_xdr_buf for partial pages receive · ac9645c8
    Dan Aloni authored
    When receiving pages data, return value 'ret' when positive includes
    `buf->page_base`, so we should subtract that before it is used for
    changing `offset` and comparing against `want`.
    
    This was discovered on the very rare cases where the server returned a
    chunk of bytes that when added to the already received amount of bytes
    for the pages happened to match the current `recv.len`, for example
    on this case:
    
         buf->page_base : 258356
         actually received from socket: 1740
         ret : 260096
         want : 260096
    
    In this case neither of the two 'if ... goto out' trigger, and we
    continue to tail parsing.
    
    Worth to mention that the ensuing EMSGSIZE from the continued execution of
    `xs_read_xdr_buf` may be observed by an application due to 4 superfluous
    bytes being added to the pages data.
    
    Fixes: 277e4ab7 ("SUNRPC: Simplify TCP receive code by switching to using iterators")
    Signed-off-by: default avatarDan Aloni <dan@kernelim.com>
    Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
    ac9645c8
xprtsock.c 81.7 KB