• Bob Peterson's avatar
    Revert "gfs2: Don't demote a glock until its revokes are written" · acc014ae
    Bob Peterson authored
    [ Upstream commit b14c9490 ]
    
    This reverts commit df5db5f9.
    
    This patch fixes a regression: patch df5db5f9 allowed function
    run_queue() to bypass its call to do_xmote() if revokes were queued for
    the glock. That's wrong because its call to do_xmote() is what is
    responsible for calling the go_sync() glops functions to sync both
    the ail list and any revokes queued for it. By bypassing the call,
    gfs2 could get into a stand-off where the glock could not be demoted
    until its revokes are written back, but the revokes would not be
    written back because do_xmote() was never called.
    
    It "sort of" works, however, because there are other mechanisms like
    the log flush daemon (logd) that can sync the ail items and revokes,
    if it deems it necessary. The problem is: without file system pressure,
    it might never deem it necessary.
    Signed-off-by: default avatarBob Peterson <rpeterso@redhat.com>
    Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
    acc014ae
glock.c 54.5 KB