• Finn Thain's avatar
    ncr5380: Eliminate selecting state · ae753a33
    Finn Thain authored
    Linux v2.1.105 changed the algorithm for polling for the BSY signal
    in NCR5380_select() and NCR5380_main().
    
    Presently, this code has a bug. Back then, NCR5380_set_timer(hostdata, 1)
    meant reschedule main() after sleeping for 10 ms. Repeated 25 times this
    provided the recommended 250 ms selection time-out delay. This got broken
    when HZ became configurable.
    
    We could fix this but there's no need to reschedule the main loop. This
    BSY polling presently happens when the NCR5380_main() work queue item
    calls NCR5380_select(), which in turn schedules NCR5380_main(), which
    calls NCR5380_select() again, and so on.
    
    This algorithm is a deviation from the simpler one in atari_NCR5380.c.
    The extra complexity and state is pointless. There's no reason to
    stop selection half-way and return to to the main loop when the main
    loop can do nothing useful until selection completes.
    
    So just poll for BSY. We can sleep while polling now that we have a
    suitable workqueue.
    Signed-off-by: default avatarFinn Thain <fthain@telegraphics.com.au>
    Reviewed-by: default avatarHannes Reinecke <hare@suse.com>
    Tested-by: default avatarOndrej Zary <linux@rainbow-software.org>
    Tested-by: default avatarMichael Schmitz <schmitzmic@gmail.com>
    Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
    ae753a33
NCR5380.c 86.2 KB