Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • L linux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Kirill Smelkov
  • linux
  • Repository
You need to sign in or sign up before continuing.
  • linux
  • lib
  • stackdepot.c
Find file BlameHistoryPermalink
  • Peter Collingbourne's avatar
    stackdepot: rename pool_index to pool_index_plus_1 · a6c1d9cb
    Peter Collingbourne authored Apr 01, 2024
    Commit 3ee34eab ("lib/stackdepot: fix first entry having a 0-handle")
    changed the meaning of the pool_index field to mean "the pool index plus
    1".  This made the code accessing this field less self-documenting, as
    well as causing debuggers such as drgn to not be able to easily remain
    compatible with both old and new kernels, because they typically do that
    by testing for presence of the new field.  Because stackdepot is a
    debugging tool, we should make sure that it is debugger friendly. 
    Therefore, give the field a different name to improve readability as well
    as enabling debugger backwards compatibility.
    
    This is needed in 6.9, which would otherwise become an odd release with
    the new semantics and old name so debuggers wouldn't recognize the new
    semantics there.
    
    Fixes: 3ee34eab ("lib/stackdepot: fix first entry having a 0-handle")
    Link: https://lkml.kernel.org/r/20240402001500.53533-1-pcc@google.com
    Link: https://linux-review.googlesource.com/id/Ib3e70c36c1d230dd0a118dc22649b33e768b9f88
    
    
    Signed-off-by: default avatarPeter Collingbourne <pcc@google.com>
    Acked-by: default avatarVlastimil Babka <vbabka@suse.cz>
    Reviewed-by: default avatarAlexander Potapenko <glider@google.com>
    Acked-by: default avatarMarco Elver <elver@google.com>
    Acked-by: default avatarOscar Salvador <osalvador@suse.de>
    Cc: Andrey Konovalov <andreyknvl@gmail.com>
    Cc: Michal Hocko <mhocko@suse.com>
    Cc: Omar Sandoval <osandov@fb.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    a6c1d9cb
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7