• Bitterblue Smith's avatar
    wifi: rtl8xxxu: Don't print the vendor/product/serial · af8678e6
    Bitterblue Smith authored
    Most devices have a vendor name, product name, and serial number in the
    efuse, but it's pretty useless. It duplicates the information already
    printed by the USB subsystem:
    
       usb 1-4: New USB device found, idVendor=0bda, idProduct=8178, bcdDevice= 2.00
       usb 1-4: New USB device strings: Mfr=1, Product=2, SerialNumber=3
       usb 1-4: Product: 802.11n WLAN Adapter
       usb 1-4: Manufacturer: Realtek
       usb 1-4: SerialNumber: 00e04c000001
    -> usb 1-4: Vendor: Realtek
    -> usb 1-4: Product: 802.11n WLAN Adapter
    
       usb 1-4: New USB device found, idVendor=0bda, idProduct=818b, bcdDevice= 2.00
       usb 1-4: New USB device strings: Mfr=1, Product=2, SerialNumber=3
       usb 1-4: Product: 802.11n NIC
       usb 1-4: Manufacturer: Realtek
       usb 1-4: SerialNumber: 00e04c000001
    -> usb 1-4: Vendor: Realtek
    -> usb 1-4: Product: 802.11n NIC
    -> usb 1-4: Serial not available.
    
       usb 1-4: New USB device found, idVendor=0bda, idProduct=f179, bcdDevice= 0.00
       usb 1-4: New USB device strings: Mfr=1, Product=2, SerialNumber=3
       usb 1-4: Product: 802.11n
       usb 1-4: Manufacturer: Realtek
       usb 1-4: SerialNumber: 002E2DC0041F
    -> usb 1-4: Vendor: Realtek
    -> usb 1-4: Product: 802.11n
    
       usb 1-4: New USB device found, idVendor=0bda, idProduct=8179, bcdDevice= 0.00
       usb 1-4: New USB device strings: Mfr=1, Product=2, SerialNumber=3
       usb 1-4: Product: 802.11n NIC
       usb 1-4: Manufacturer: Realtek
       usb 1-4: SerialNumber: 00E04C0001
    -> usb 1-4: Vendor: Realtek
    -> usb 1-4: Product: 802.11n NIC
    -> usb 1-4: Serial: 00E04C0001
    
    Also, that data is not interpreted correctly in all cases:
    
    usb 3-1.1.2: New USB device found, idVendor=0bda, idProduct=8179, bcdDevice= 0.00
    usb 3-1.1.2: New USB device strings: Mfr=1, Product=2, SerialNumber=3
    usb 3-1.1.2: Product: 802.11n NIC
    usb 3-1.1.2: Manufacturer: Realtek
    usb 3-1.1.2: Vendor: Realtek
    usb 3-1.1.2: Product: \x03802.11n NI
    usb 3-1.1.2: Serial: \xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff
    
    Link: https://bugzilla.kernel.org/show_bug.cgi?id=217231Signed-off-by: default avatarBitterblue Smith <rtl8821cerfe2@gmail.com>
    Reviewed-by: default avatarPing-Ke Shih <pkshih@realtek.com>
    Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
    Link: https://lore.kernel.org/r/a2a7d9df-0529-7890-3522-48dce613753f@gmail.com
    af8678e6
rtl8xxxu_8188e.c 54 KB