• Wenwei Tao's avatar
    cgroup: remove redundant cleanup in css_create · b00c52da
    Wenwei Tao authored
    When create css failed, before call css_free_rcu_fn, we remove the css
    id and exit the percpu_ref, but we will do these again in
    css_free_work_fn, so they are redundant.  Especially the css id, that
    would cause problem if we remove it twice, since it may be assigned to
    another css after the first remove.
    
    tj: This was broken by two commits updating the free path without
        synchronizing the creation failure path.  This can be easily
        triggered by trying to create more than 64k memory cgroups.
    Signed-off-by: default avatarWenwei Tao <ww.tao0320@gmail.com>
    Signed-off-by: default avatarTejun Heo <tj@kernel.org>
    Cc: Vladimir Davydov <vdavydov@parallels.com>
    Fixes: 9a1049da ("percpu-refcount: require percpu_ref to be exited explicitly")
    Fixes: 01e58659 ("cgroup: release css->id after css_free")
    Cc: stable@vger.kernel.org # v3.17+
    b00c52da
cgroup.c 174 KB