• Paul Gortmaker's avatar
    clocksource/drivers/mips-gic-timer: Make gic_clocksource_of_init() return int · be5769e2
    Paul Gortmaker authored
    In commit:
    
      d8152bf8 ("clocksource/drivers/mips-gic-timer: Convert init function to return error")
    
    several return values were added to a void function resulting in the following warnings:
    
     clocksource/mips-gic-timer.c: In function 'gic_clocksource_of_init':
     clocksource/mips-gic-timer.c:175:3: warning: 'return' with a value, in function returning void [enabled by default]
     clocksource/mips-gic-timer.c:183:4: warning: 'return' with a value, in function returning void [enabled by default]
     clocksource/mips-gic-timer.c:190:3: warning: 'return' with a value, in function returning void [enabled by default]
     clocksource/mips-gic-timer.c:195:3: warning: 'return' with a value, in function returning void [enabled by default]
     clocksource/mips-gic-timer.c:200:3: warning: 'return' with a value, in function returning void [enabled by default]
     clocksource/mips-gic-timer.c:211:2: warning: 'return' with a value, in function returning void [enabled by default]
     clocksource/mips-gic-timer.c: At top level:
     clocksource/mips-gic-timer.c:213:1: warning: comparison of distinct pointer types lacks a cast [enabled by default]
     clocksource/mips-gic-timer.c: In function 'gic_clocksource_of_init':
     clocksource/mips-gic-timer.c:183:18: warning: ignoring return value of 'PTR_ERR', declared with attribute warn_unused_result [-Wunused-result]
    
    Given that the addition of the return values was intentional, it seems
    that the conversion of the containing function from void to int was
    simply overlooked.
    Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
    Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: linux-mips@linux-mips.org
    Fixes: d8152bf8 ("clocksource/drivers/mips-gic-timer: Convert init function to return error")
    Link: http://lkml.kernel.org/r/1471429296-9053-3-git-send-email-daniel.lezcano@linaro.orgSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    be5769e2
mips-gic-timer.c 4.98 KB