• Hans Verkuil's avatar
    media: b2c2: flexcop-usb: fix flexcop_usb_memory_req · b178aa6f
    Hans Verkuil authored
    smatch generated this warning:
    
    drivers/media/usb/b2c2/flexcop-usb.c:199 flexcop_usb_memory_req() warn: iterator 'i' not incremented
    
    and indeed the function is not using i or updating buf.
    
    The reason this always worked is that this function is called to write just
    6 bytes (a MAC address) to the USB device, and so in practice there is only
    a single chunk written. If we ever would need to write more than one chunk,
    this function would fail since each chunk would read from or write to the
    same buf address.
    
    Rewrite the function to properly handle this.
    Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
    b178aa6f
flexcop-usb.c 16.6 KB