• NeilBrown's avatar
    md/raid5: fix another livelock caused by non-aligned writes. · b1b02fe9
    NeilBrown authored
    If a non-page-aligned write is destined for a device which
    is missing/faulty, we can deadlock.
    
    As the target device is missing, a read-modify-write cycle
    is not possible.
    As the write is not for a full-page, a recontruct-write cycle
    is not possible.
    
    This should be handled by logic in fetch_block() which notices
    there is a non-R5_OVERWRITE write to a missing device, and so
    loads all blocks.
    
    However since commit 67f45548, that code requires
    STRIPE_PREREAD_ACTIVE before it will active, and those circumstances
    never set STRIPE_PREREAD_ACTIVE.
    
    So: in handle_stripe_dirtying, if neither rmw or rcw was possible,
    set STRIPE_DELAYED, which will cause STRIPE_PREREAD_ACTIVE be set
    after a suitable delay.
    
    Fixes: 67f45548
    Cc: stable@vger.kernel.org (v3.16+)
    Reported-by: default avatarMikulas Patocka <mpatocka@redhat.com>
    Tested-by: default avatarHeinz Mauelshagen <heinzm@redhat.com>
    Signed-off-by: default avatarNeilBrown <neilb@suse.de>
    b1b02fe9
raid5.c 201 KB