• Cong Wang's avatar
    net_sched: hold rtnl lock in tcindex_partial_destroy_work() · b1be2e8c
    Cong Wang authored
    syzbot reported a use-after-free in tcindex_dump(). This is due to
    the lack of RTNL in the deferred rcu work. We queue this work with
    RTNL in tcindex_change(), later, tcindex_dump() is called:
    
            fh = tp->ops->get(tp, t->tcm_handle);
    	...
            err = tp->ops->change(..., &fh, ...);
            tfilter_notify(..., fh, ...);
    
    but there is nothing to serialize the pending
    tcindex_partial_destroy_work() with tcindex_dump().
    
    Fix this by simply holding RTNL in tcindex_partial_destroy_work(),
    so that it won't be called until RTNL is released after
    tc_new_tfilter() is completed.
    
    Reported-and-tested-by: syzbot+653090db2562495901dc@syzkaller.appspotmail.com
    Fixes: 3d210534 ("net_sched: fix a race condition in tcindex_destroy()")
    Cc: Jamal Hadi Salim <jhs@mojatatu.com>
    Cc: Jiri Pirko <jiri@resnulli.us>
    Signed-off-by: default avatarCong Wang <xiyou.wangcong@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    b1be2e8c
cls_tcindex.c 16.4 KB