• Roland Dreier's avatar
    IB/fmr: ib_flush_fmr_pool() may wait too long · f47e22c6
    Roland Dreier authored
    ib_flush_fmr_pool() stashes away the request generation number
    properly, but then goes ahead and rereads it every time it tests
    whether the flush generation number has caught up.  This means that
    there is a theoretical possibility of livelock, if the request
    generation number keeps getting bumped and the flush generation number
    never catches up.  The fix is simple: use the request generation
    number read at the beginning of the function.
    
    Also, atomic_inc() followed by atomic_read() can be replaced with
    atomic_int_return().  There's no real requirement for atomicity here
    but we might as well shrink the code.
    
    This bug was discovered using David Binderman's list of "set but never
    used" warnings from icc.
    Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
    f47e22c6
fmr_pool.c 13.7 KB