• Suren Baghdasaryan's avatar
    swap: remove remnants of polling from read_swap_cache_async · b243dcbf
    Suren Baghdasaryan authored
    Patch series "Per-VMA lock support for swap and userfaults", v7.
    
    When per-VMA locks were introduced in [1] several types of page faults
    would still fall back to mmap_lock to keep the patchset simple.  Among
    them are swap and userfault pages.  The main reason for skipping those
    cases was the fact that mmap_lock could be dropped while handling these
    faults and that required additional logic to be implemented.  Implement
    the mechanism to allow per-VMA locks to be dropped for these cases.
    
    First, change handle_mm_fault to drop per-VMA locks when returning
    VM_FAULT_RETRY or VM_FAULT_COMPLETED to be consistent with the way
    mmap_lock is handled.  Then change folio_lock_or_retry to accept vm_fault
    and return vm_fault_t which simplifies later patches.  Finally allow swap
    and uffd page faults to be handled under per-VMA locks by dropping per-VMA
    and retrying, the same way it's done under mmap_lock.  Naturally, once VMA
    lock is dropped that VMA should be assumed unstable and can't be used.
    
    
    This patch (of 6):
    
    Commit [1] introduced IO polling support duding swapin to reduce swap read
    latency for block devices that can be polled.  However later commit [2]
    removed polling support.  Therefore it seems safe to remove do_poll
    parameter in read_swap_cache_async and always call swap_readpage with
    synchronous=false waiting for IO completion in folio_lock_or_retry.
    
    [1] commit 23955622 ("swap: add block io poll in swapin path")
    [2] commit 9650b453 ("block: ignore RWF_HIPRI hint for sync dio")
    
    Link: https://lkml.kernel.org/r/20230630211957.1341547-1-surenb@google.com
    Link: https://lkml.kernel.org/r/20230630211957.1341547-2-surenb@google.comSigned-off-by: default avatarSuren Baghdasaryan <surenb@google.com>
    Suggested-by: default avatar"Huang, Ying" <ying.huang@intel.com>
    Reviewed-by: default avatar"Huang, Ying" <ying.huang@intel.com>
    Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
    Cc: Alistair Popple <apopple@nvidia.com>
    Cc: Al Viro <viro@zeniv.linux.org.uk>
    Cc: Christian Brauner <brauner@kernel.org>
    Cc: David Hildenbrand <david@redhat.com>
    Cc: David Howells <dhowells@redhat.com>
    Cc: Davidlohr Bueso <dave@stgolabs.net>
    Cc: Hillf Danton <hdanton@sina.com>
    Cc: Hugh Dickins <hughd@google.com>
    Cc: Jan Kara <jack@suse.cz>
    Cc: Johannes Weiner <hannes@cmpxchg.org>
    Cc: Josef Bacik <josef@toxicpanda.com>
    Cc: Laurent Dufour <ldufour@linux.ibm.com>
    Cc: Liam R. Howlett <Liam.Howlett@oracle.com>
    Cc: Lorenzo Stoakes <lstoakes@gmail.com>
    Cc: Matthew Wilcox <willy@infradead.org>
    Cc: Michal Hocko <mhocko@suse.com>
    Cc: Michel Lespinasse <michel@lespinasse.org>
    Cc: Minchan Kim <minchan@google.com>
    Cc: Pavel Tatashin <pasha.tatashin@soleen.com>
    Cc: Peter Xu <peterx@redhat.com>
    Cc: Punit Agrawal <punit.agrawal@bytedance.com>
    Cc: Vlastimil Babka <vbabka@suse.cz>
    Cc: Yu Zhao <yuzhao@google.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    b243dcbf
swap.h 3.89 KB