• Dave Martin's avatar
    serial/amba-pl011: Unconditionally poll for FIFO space before each TX char · 43dd1f9a
    Dave Martin authored
    Commit 734745ca serial/amba-pl011:
    (Activate TX IRQ passively) introduces a race which causes the driver
    sometimes to attempt to write a character to the TX FIFO when the FIFO
    is already full.
    
    The PL011 does not guarantee its behaviour when the FIFO is overfilled.
    In practice, this can cause duplicate and/or dropped characters to be
    output on the wire.  The problem is common enough to be readily
    observable on the ARM Juno platform when the PL011 UART is used as
    the console and DMA is not in use.
    
    This patch fixes this problem by always polling for space before each
    character is written to the FIFO.
    
    This will be amended to a less brute-force approach in a later commit,
    but this patch should help ensure correct behaviour for now.
    Signed-off-by: default avatarDave Martin <Dave.Martin@arm.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    43dd1f9a
amba-pl011.c 60.3 KB