• Ben Dooks's avatar
    sh_eth: ensure pm_runtime cannot suspend the device during init · b5893a08
    Ben Dooks authored
    The pm_rumtime work queue is causing the device to be suspended during
    initialisation, thus the initialisation may not be able to access registers
    properly. As the code is called from a work queue, it is possible that this
    is not seen from certain configurations/builds due to the asynchronos
    nature of the code.
    
    Another issue has also been found where the network device registration
    calls back into the driver thus causing further pm_runtime calls that
    also caused issues with the MDIO bus code. This has now been checked
    and is the only place the MDIO can be called without the device open.
    
    Use pm_runtime_get_sync() and pm_runtime_put() to ensure that the
    pm system does not suspend it during the probe() call and remove the
    now unnecessary pm_runtime_resume() call. Also add a call in the error
    path to call pm_runtime_disable().
    
    This fixes the external abort that can cause /sbin/init or other such
    init processed to die.
    Signed-off-by: default avatarBen Dooks <ben.dooks@codethink.co.uk>
    Tested-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
    Acked-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    b5893a08
sh_eth.c 70.9 KB