• Theodore Ts'o's avatar
    ext4: re-enable -o discard functionality in no-journal mode · b5e2368b
    Theodore Ts'o authored
    This is a revert of commit b56ff9d3, which removed the call to
    ext4_issue_discard() to fix a BUG reported because
    ext4_issue_discard() was being called from inside a block group
    spinlock.  As it turns out this bug had already been fixed by Lukas
    Czerner in commit 53fdcf99 by the simple expedient of moving when
    we call ext4_issue_discard() outside the spinlock.
    
    So it should be safe to re-enable this functionality, which I tested
    by putting an BUG_ON(in_atomic) just after the restored callsite to
    ext4_issue_discard().
    
    Addresses-Google-Bug: #6750518
    Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
    Cc: Anatol Pomozov <anatol.pomozov@gmail.com>
    b5e2368b
mballoc.c 138 KB