• Hans de Goede's avatar
    efi/reboot: Fall back to original power-off method if EFI_RESET_SHUTDOWN returns · b6a3780d
    Hans de Goede authored
    Commit:
    
      44be28e9 ("x86/reboot: Add EFI reboot quirk for ACPI Hardware Reduced flag")
    
    sets pm_power_off to efi_power_off() when the acpi_gbl_reduced_hardware
    flag is set.
    
    According to its commit message this is necessary because: "BayTrail-T
    class of hardware requires EFI in order to powerdown and reboot and no
    other reliable method exists".
    
    But I have a Bay Trail CR tablet where the EFI_RESET_SHUTDOWN call does
    not work, it simply returns without doing anything (AFAICT).
    
    So it seems that some Bay Trail devices must use EFI for power-off, while
    for others only ACPI works.
    
    Note that efi_power_off() only gets used if the platform code defines
    efi_poweroff_required() and that returns true, this currently only ever
    happens on x86.
    
    Since on the devices which need ACPI for power-off the EFI_RESET_SHUTDOWN
    call simply returns, this patch makes the efi-reboot code remember the
    old pm_power_off handler and if EFI_RESET_SHUTDOWN returns it falls back
    to calling that.
    
    This seems preferable to dmi-quirking our way out of this, since there
    are likely quite a few devices suffering from this.
    Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
    Signed-off-by: default avatarMatt Fleming <matt@codeblueprint.co.uk>
    Signed-off-by: default avatarArd Biesheuvel <ard.biesheuvel@linaro.org>
    Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Cc: Len Brown <lenb@kernel.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Mark Salter <msalter@redhat.com>
    Cc: Peter Jones <pjones@redhat.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: linux-efi@vger.kernel.org
    Link: http://lkml.kernel.org/r/20170818194947.19347-7-ard.biesheuvel@linaro.orgSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    b6a3780d
reboot.c 1.69 KB