• Radhey Shyam Pandey's avatar
    ata: ahci_ceva: fix error handling for Xilinx GT PHY support · 26c8404e
    Radhey Shyam Pandey authored
    Platform clock and phy error resources are not cleaned up in Xilinx GT PHY
    error path.
    
    To fix introduce the function ceva_ahci_platform_enable_resources() which
    is a customized version of ahci_platform_enable_resources() and inline with
    SATA IP programming sequence it does:
    
    - Assert SATA reset
    - Program PS GTR phy
    - Bring SATA by de-asserting the reset
    - Wait for GT lane PLL to be locked
    
    ceva_ahci_platform_enable_resources() is also used in the resume path
    as the same SATA programming sequence (as in probe) should be followed.
    Also cleanup the mixed usage of ahci_platform_enable_resources() and custom
    implementation in the probe function as both are not required.
    
    Fixes: 9a9d3abe ("ata: ahci: ceva: Update the driver to support xilinx GT phy")
    Signed-off-by: default avatarRadhey Shyam Pandey <radhey.shyam.pandey@amd.com>
    Reviewed-by: default avatarDamien Le Moal <dlemoal@kernel.org>
    Signed-off-by: default avatarNiklas Cassel <cassel@kernel.org>
    26c8404e
ahci_ceva.c 10.6 KB