• Oleksij Rempel's avatar
    net: bridge: switchdev: Improve error message for port_obj_add/del functions · b7ffab29
    Oleksij Rempel authored
    Enhance the error reporting mechanism in the switchdev framework to
    provide more informative and user-friendly error messages.
    
    Following feedback from users struggling to understand the implications
    of error messages like "failed (err=-28) to add object (id=2)", this
    update aims to clarify what operation failed and how this might impact
    the system or network.
    
    With this change, error messages now include a description of the failed
    operation, the specific object involved, and a brief explanation of the
    potential impact on the system. This approach helps administrators and
    developers better understand the context and severity of errors,
    facilitating quicker and more effective troubleshooting.
    
    Example of the improved logging:
    
    [   70.516446] ksz-switch spi0.0 uplink: Failed to add Port Multicast
                   Database entry (object id=2) with error: -ENOSPC (-28).
    [   70.516446] Failure in updating the port's Multicast Database could
                   lead to multicast forwarding issues.
    [   70.516446] Current HW/SW setup lacks sufficient resources.
    
    This comprehensive update includes handling for a range of switchdev
    object IDs, ensuring that most operations within the switchdev framework
    benefit from clearer error reporting.
    Reviewed-by: default avatarSimon Horman <horms@kernel.org>
    Signed-off-by: default avatarOleksij Rempel <o.rempel@pengutronix.de>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    b7ffab29
switchdev.c 31.2 KB