• Stephen Boyd's avatar
    firmware: coreboot: Let OF core populate platform device · 09ed061a
    Stephen Boyd authored
    Now that the /firmware/coreboot node in DT is populated by the core DT
    platform code with commit 3aa0582f ("of: platform: populate
    /firmware/ node from of_platform_default_populate_init()") we should and
    can remove the platform device creation here. Otherwise, the
    of_platform_device_create() call will fail, the coreboot of driver won't
    be registered, and this driver will never bind. At the same time, we
    should move this driver to use MODULE_DEVICE_TABLE so that module
    auto-load works properly when the coreboot device is auto-populated and
    we should drop the of_node handling that was presumably placed here to
    hold a reference to the DT node created during module init that no
    longer happens.
    
    Cc: Wei-Ning Huang <wnhuang@chromium.org>
    Cc: Julius Werner <jwerner@chromium.org>
    Reviewed-by: default avatarBrian Norris <briannorris@chromium.org>
    Cc: Samuel Holland <samuel@sholland.org>
    Reviewed-by: default avatarSudeep Holla <Sudeep.Holla@arm.com>
    Fixes: 3aa0582f ("of: platform: populate /firmware/ node from of_platform_default_populate_init()")
    Signed-off-by: default avatarStephen Boyd <swboyd@chromium.org>
    Reviewed-by: default avatarJulius Werner <jwerner@chromium.org>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    09ed061a
coreboot_table-of.c 1.49 KB