• Kajol Jain's avatar
    perf vendor events power10: Fix hv-24x7 metric events · b92dd117
    Kajol Jain authored
    Testcase stat_all_metrics.sh fails in powerpc:
    
      90: perf all metrics test : FAILED!
    
    The testcase "stat_all_metrics.sh" verifies perf stat result for all the
    metric events present in perf list.  It runs perf metric events with
    various commands and expects non-empty metric result.
    
    Incase of powerpc:hv-24x7 events, some of the event count can be 0 based
    on system configuration. And if that event used as denominator in divide
    equation, it can cause divide by 0 error. The current nest_metric.json
    file creating divide by 0 issue for some of the metric events, which
    results in failure of the "stat_all_metrics.sh" test case.
    
    Most of the metrics events have cycles or an event which expect to have
    a larger value as denominator, so adding 1 to the denominator of the
    metric expression as a fix.
    
    Result in powerpc box after this patch changes:
    
      90: perf all metrics test : Ok
    
    Fixes: a3cbcadf ("perf vendor events power10: Adds 24x7 nest metric events for power10 platform")
    Signed-off-by: default avatarKajol Jain <kjain@linux.ibm.com>
    Reviewed-by: default avatarMadhavan Srinivasan <maddy@linux.vnet.ibm.com>
    Cc: Athira Jajeev <atrajeev@linux.vnet.ibm.com>
    Cc: Disha Goel <disgoel@linux.vnet.ibm.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Kajol Jain <kjain@linux.ibm.com>
    Cc: linuxppc-dev@lists.ozlabs.org
    Cc: Michael Ellerman <mpe@ellerman.id.au>
    Cc: Nageswara R Sastry <rnsastry@linux.ibm.com>
    Link: https://lore.kernel.org/r/20221014140220.122251-1-kjain@linux.ibm.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    b92dd117
nest_metrics.json 20.1 KB