• Georgiana Rodica Chelu's avatar
    staging: rtl8188eu: hal: rtl8188e_cmd: Use ether_addr_copy() instead of memcpy() · b95300e8
    Georgiana Rodica Chelu authored
    The checkpatch.pl found the warning:
    WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet
    addresses are __aligned(2)
    
    Checked if the the Ethernet addresses are __aligned(2) by using pahole
    tool. The type of pwlanhdr is struct ieee80211_hdr and pahole shows that
    addr1, addr2, and addr3 are aligned to u16.
    
    struct ieee80211_hdr {
            __le16                     frame_control;        /*     0     2 */
            __le16                     duration_id;          /*     2     2 */
            u8                         addr1[6];             /*     4     6 */
            u8                         addr2[6];             /*    10     6 */
            u8                         addr3[6];             /*    16     6 */
            __le16                     seq_ctrl;             /*    22     2 */
            u8                         addr4[6];             /*    24     6 */
    
            /* size: 30, cachelines: 1, members: 7 */
            /* last cacheline: 30 bytes */
    };
    
    Both eeprompriv from struct adapter and MacAddress from struct
    wlan_bssid_ex have the offset multiple of sizeof(u16).
    
    Also, the array bc_addr and the pointers: StaAddr, mac, and bssid,
    start from an even offset.
    Signed-off-by: default avatarGeorgiana Rodica Chelu <georgiana.chelu93@gmail.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    b95300e8
rtl8188e_cmd.c 19.2 KB