• Stas Sergeev's avatar
    add fixed_phy_update_state() - update state of fixed_phy · a3bebdce
    Stas Sergeev authored
    Currently fixed_phy uses a callback to periodically poll the link state.
    This patch adds the fixed_phy_update_state() API.
    It solves the following problems:
    - On link state interrupt, MAC driver can't update status.
    Instead it needs to provide the callback to periodically query
    the HW about the link state. It is more efficient to update status
    after interrupt.
    - The callback needs to be unregistered before phy_disconnect(),
    or otherwise it will be called with net_dev==NULL. phy_disconnect()
    does not have enough info to unregister the callback automatically.
    - The callback needs to be registered before of_phy_connect() to
    avoid running with outdated state, but of_phy_connect() returns the
    phy_device pointer, which is needed to register the callback. Registering
    it before of_phy_connect() will therefore require a hack to get the
    pointer earlier.
    
    Overall, this addition makes the subsequent patch that implements
    SGMII link status for mvneta, much cleaner.
    
    CC: Florian Fainelli <f.fainelli@gmail.com>
    CC: netdev@vger.kernel.org
    CC: linux-kernel@vger.kernel.org
    Signed-off-by: default avatarStas Sergeev <stsp@users.sourceforge.net>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    a3bebdce
fixed_phy.c 7.67 KB