• Arnd Bergmann's avatar
    media: nxp: imx8-isi: fix buiding on 32-bit · ba0ad6ed
    Arnd Bergmann authored
    The #if check is wrong, leading to a build failure:
    
      drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c: In function 'mxc_isi_channel_set_inbuf':
      drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c:33:5: error: "CONFIG_ARCH_DMA_ADDR_T_64BIT" is not defined, evaluates to 0 [-Werror=undef]
         33 | #if CONFIG_ARCH_DMA_ADDR_T_64BIT
            |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    This could just be an #ifdef, but it seems nicer to just remove the
    check entirely.  Apparently the only reason for the #ifdef is to avoid
    another warning:
    
      drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c:55:24: error: right shift count >= width of type [-Werror=shift-count-overflow]
    
    But this is best avoided by using the lower_32_bits()/upper_32_bits()
    helpers.
    
    Fixes: cf21f328 ("media: nxp: Add i.MX8 ISI driver")
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    ba0ad6ed
imx8-isi-hw.c 16.7 KB