• Andy Yan's avatar
    ARM: dts: rockchip: Remove rockchip,default-sample-phase from rk3036.dtsi · bb0b255f
    Andy Yan authored
    This should be a per board property, should not be put in
    a soc core dtsi.
    
    And when this property convert from default-sample-phase
    in linux-5.7 by commit 8a385eb5 ("ARM: dts: rockchip: fix
    rockchip,default-sample-phase property names"), the emmc
    on rk3036 kylin board get a initialising error:
    
    [    4.512797] Freeing unused kernel memory: 8192K
    [    4.519500] mmc_host mmc1: Bus speed (slot 0) = 37125000Hz (slot req 37500000Hz, actual 37125000HZ div = 0)
    [    4.530971] mmc1: error -84 whilst initialising MMC card
    [    4.537277] Run /init as init process
    [    4.550932] mmc_host mmc1: Bus speed (slot 0) = 300000Hz (slot req 300000Hz, actual 300000HZ div = 0)
    [    4.664717] mmc_host mmc1: Bus speed (slot 0) = 37125000Hz (slot req 37500000Hz, actual 37125000HZ div = 0)
    [    4.676156] mmc1: error -84 whilst initialising MMC card
    
    I think the reason why the emmc on rk3036 kylin board was able
    to work before linux-5.7 was that the illegal property was not
    correctly identified by the rockchip dw_mmc driver.
    
    Fixes: faea098e ("ARM: dts: rockchip: add core rk3036 dtsi")
    Signed-off-by: default avatarAndy Yan <andy.yan@rock-chips.com>
    Reviewed-by: default avatarShawn Lin <shawn.lin@rock-chips.com>
    Link: https://lore.kernel.org/r/20231218105523.2478315-4-andyshrk@163.comSigned-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
    bb0b255f
rk3036.dtsi 21.3 KB